Do lmr for more captures. #2420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good performance for this patch, but I wonder about something with this patch and vondele's : how does it behave in deep searches ? If someone uses a bigger than optimal TT size, it's quite easy to reduce it to match the TC. But for long searches, one often cannot use a bigger hash. Do we know how the tthitrate would behave in this situation ? |
|
If we do end up changing this, next time could it be tried without a divide operation? |
|
Many congratulations!! to one and only @my :) |
|
@ddugovic the divide can actually be optimized at compile time (i.e. the whole right hand side is a constant) and so is for free. |
|
Merged via 3f41913, congrats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passed STC
http://tests.stockfishchess.org/tests/view/5dd4d51df531e81cf278eaac
LLR: 2.97 (-2.94,2.94) [-1.50,4.50]
Total: 16495 W: 3591 L: 3434 D: 9470
passed LTC
http://tests.stockfishchess.org/tests/view/5dd52265f531e81cf278eace
LLR: 2.96 (-2.94,2.94) [0.00,3.50]
Total: 23598 W: 3956 L: 3716 D: 15926
based on machinery introduced by vondele. Logic behind patch if relatively simple - if we reduce less with high hitrate of TT somewhat logical is to reduce more with low hitrate. For example enable all captures for LMR.
Constant is arbitrary and can be tweaked. :)
bench 5183523